Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Psalm returns exit code 0 when a plugin causes a type error #3243

Closed
mr-feek opened this issue Apr 27, 2020 · 2 comments
Closed

[Bug] Psalm returns exit code 0 when a plugin causes a type error #3243

mr-feek opened this issue Apr 27, 2020 · 2 comments
Labels
bug easy problems Issues that can be fixed without background knowledge of Psalm

Comments

@mr-feek
Copy link
Contributor

mr-feek commented Apr 27, 2020

Actual

In NodeDataProvider.php line 41:

    Argument 2 passed to Psalm\Internal\Provider\NodeDataProvider::setType() must be an instance of Psalm\Type\Union, instance of Psalm\Type\Atomic\TGenericObject given, called in /Users/fiachra/repos/psalm-plugin-laravel/vendor/vimeo/ps
    alm/src/Psalm/Internal/Analyzer/Statements/Expression/Call/StaticCallAnalyzer.php on line 1183


  Psalm exit code: 0

Expected

I would expect the exit code to be 1

@psalm-github-bot
Copy link

Hey @mr-feek, can you reproduce the issue on https://psalm.dev ?

@weirdan weirdan added bug easy problems Issues that can be fixed without background knowledge of Psalm labels Apr 27, 2020
@mr-feek
Copy link
Contributor Author

mr-feek commented May 3, 2020

After more debugging than I care to admit, this happened because underlying code in the laravel plugin was setting its own exception handler, overrriding psalm's.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug easy problems Issues that can be fixed without background knowledge of Psalm
Projects
None yet
Development

No branches or pull requests

2 participants