-
Notifications
You must be signed in to change notification settings - Fork 664
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
1 changed file
with
2 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
575da79
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @danog
Thanks for this quick fix! so far it looks like a black magic to me. :) I would love to know more about it and how it helped to bypass the issue. If it's not difficult to you, can you please share some details about the solution?
575da79
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing too complicated, I just noticed that the issue went away when var_dumping the variables, so I assumed that calling any function before that assertion would somehow reorder values on the stack or do something else that bypasses the issue.
I assume I could've digged in some more to find out why this bypasses the issue, but dstogov already fixed the issue upstream so it doesn't really matter, this just a hotfix until php 8.1.17 and 8.2.4 are released, at which point I'll probably add a conflict section to psalm's composer.json to avoid loading broken versions of php.
dstogov/php-src@84cd1cc
575da79
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, thanks a lot for these details! 👍