Support JWT types other than refresh and access #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an "refresh" is "access" Cloudflare Teams JWT auth for example, sets a token with a value of "app".
|
Nice, at a glance I like how this looks! Let me look at it closer when I have some more time tomorrow and I can get it merged and a new release cut for you 👍 |
vimalloc
reviewed
Mar 9, 2021
|
|
||
|
|
||
| def verify_token_not_blocklisted(jwt_header, jwt_data, request_type): | ||
| def verify_token_not_blocklisted(jwt_header, jwt_data): |
There was a problem hiding this comment.
Nice, thanks for cleaning this up 👍
|
Released in version 4.1.0 (https://github.com/vimalloc/flask-jwt-extended/releases/tag/4.1.0). Thanks for contributing! 👍 |
This was referenced Mar 10, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My team use the Cloudflare Team's identity service to authenticate and pass JWT tokens to our apps. We've been attempting to use flask-jwt-extended to verify JWT tokens within our flask apps, but have run into a bit of a problem. There seems to be an assumption that the only token types that can be used are
refreshoraccesstokens, but Cloudflare at least sets"type": "app"within the payload. I haven't been able to find a spec anywhere that says onlyaccessandrefreshare valid, and regardless Cloudflare obviously uses a different value.Here's a PR to alter the library to support more token types. All tests are passing, but there may be some changes that merit more thought, I'm happy to take suggestions.