fix: safari hls #48
Merged
fix: safari hls #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonocasey
force-pushed
the
fix/safari-hls
branch
from
b73dedd to
70fbcbc
Compare
brandonocasey
commented
Jan 22, 2018
|
|
||
| // import controls so they get regisetered with videojs | ||
| import './cardboard-button'; | ||
| import './big-vr-play-button'; | ||
|
|
||
| const validProjections = [ |
There was a problem hiding this comment.
moved to utils
brandonocasey
commented
Jan 22, 2018
| @@ -46,51 +33,6 @@ const errors = { | |||
| } | |||
| }; | |||
|
|
|||
| const getInternalProjectionName = function(projection) { | |||
There was a problem hiding this comment.
moved to utils
brandonocasey
commented
Jan 22, 2018
| if (videojs.browser.IE_VERSION) { | ||
| // IE 11 does not support enough webgl to be supported | ||
| // older safari does not support cors, so it wont work | ||
| if (videojs.browser.IE_VERSION || !utils.corsSupport) { |
There was a problem hiding this comment.
older version of safari that don't support cors at all (<9 wont work), they dont work right now.
brandonocasey
commented
Jan 22, 2018
| this.videoTexture.format = THREE.RGBFormat; | ||
| } | ||
| // https://bugs.webkit.org/show_bug.cgi?id=179417 | ||
| if (videojs.browser.IS_ANY_SAFARI && utils.isHLS(this.player_.currentSource().type)) { |
There was a problem hiding this comment.
previously we had a hack to get video textures working here. This uses a canvas image texture that is updated to the current video frame instead. This makes safari 10 and 11 both work for all versions but it can be a bit slower on worse hardware, and it probably doesn't look as good.
There was a problem hiding this comment.
From my testing on an iPAD It preforms well enough that I think its a solution.
misteroneill
approved these changes
Jan 24, 2018
|
QA LGTM |
brandonocasey
force-pushed
the
fix/safari-hls
branch
from
6f5047c to
1995f20
Compare
brandonocasey
added a commit
that referenced
this pull request
Jan 31, 2018
* use "software rendering" to fix safari hls * add an error for hls cors issues * fix animation frame looping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.