Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Spatial audio rendering via Omnitone #181

Merged
merged 20 commits into from
Sep 9, 2019
Merged

Add support for Spatial audio rendering via Omnitone #181

merged 20 commits into from
Sep 9, 2019

Conversation

gjanblaszczyk
Copy link
Member

Description

Adds support for Spatial audio rendering.

Specific Changes proposed

This PR adds support for Spatial audio rendering via Omnitone library.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Unit Tests updated or fixed
    • Docs/guides updated
  • Reviewed by Two Core Contributors

@gjanblaszczyk
Copy link
Member Author

Hi @gkatsev, I know that you are very busy now but Is it there any chance to review the PR soon?

@gjanblaszczyk
Copy link
Member Author

The PR is also related to #69

brandonocasey
brandonocasey requested changes Aug 21, 2019
View reviewed changes
src/plugin.js Outdated Show resolved Hide resolved
src/plugin.js Outdated Show resolved Hide resolved
src/plugin.js Show resolved Hide resolved
examples/spatial.html Outdated Show resolved Hide resolved
gkatsev
gkatsev reviewed Aug 21, 2019
View reviewed changes
Copy link
Member

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependency Injection is all the rage now, right?

We can have omnitone as a dev dep for tests and local examples and what not.

src/plugin.js Show resolved Hide resolved
src/plugin.js Outdated Show resolved Hide resolved
brandonocasey
brandonocasey reviewed Sep 6, 2019
View reviewed changes
Copy link
Contributor

@brandonocasey brandonocasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the inclusion of Omniture, and getting the spatial example to work this looks good!

package.json Outdated Show resolved Hide resolved
scripts/rollup.config.js Outdated Show resolved Hide resolved
src/omnitone-controller.js Outdated Show resolved Hide resolved
src/omnitone-controller.js Outdated Show resolved Hide resolved
@brandonocasey brandonocasey merged commit 2af9aa3 into videojs:master Sep 9, 2019
@brandonocasey
Copy link
Contributor

This is out as 1.7.0

@gkatsev
Copy link
Member

gkatsev commented Nov 18, 2019

FYI, this PR overwrote the URLs in the package-lock file from npmjs registry urls to screen9 urls:

-      "resolved": "http://devnpm.sr4.screen9.com:80/ansi-escapes/-/ansi-escapes-1.4.0.tgz",
+      "resolved": "https://registry.npmjs.org/ansi-escapes/-/ansi-escapes-1.4.0.tgz",

@gjanblaszczyk
Copy link
Member Author

Ups, Somehow I missed that package-lock changes... Sorry for the problem.

@gkatsev
Copy link
Member

gkatsev commented Nov 19, 2019

No worries, this happens and it's been fixed 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandonocasey brandonocasey brandonocasey approved these changes

@gkatsev gkatsev gkatsev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gjanblaszczyk @brandonocasey @gkatsev