Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: VR switches to the lowest resolution after loading 1 HLS chunk on HLS 360 video #177

Merged
merged 2 commits into from
Aug 21, 2019

Conversation

gjanblaszczyk
Copy link
Member

@gjanblaszczyk gjanblaszczyk commented Jun 18, 2019

Description

The http-streaming switches VR video to the lowest resolution available in HLS manifest after loading 1
HLS chunk on HLS 360 video.
The problem is related to http-streaming and adaptive algorithm. The adaptive login will only work correctly when video tag has a width and height but the VR plugin sets display: none on video tag element which makes video tag width and height equal to 0.

Specific Changes proposed

We should use opacity: 0 instead of display: none and insert canvas element after the video tag element to make it clickable.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Unit Tests updated or fixed
    • Docs/guides updated
  • Reviewed by Two Core Contributors

@gjanblaszczyk gjanblaszczyk changed the title fix: VR switches to low res. after 1 chunk on HLS fix: VR switches to lowest resolution after loading 1 HLS chunk on HLS 360 video Jun 18, 2019
@gjanblaszczyk gjanblaszczyk changed the title fix: VR switches to lowest resolution after loading 1 HLS chunk on HLS 360 video fix: VR switches to the lowest resolution after loading 1 HLS chunk on HLS 360 video Jun 18, 2019
@brandonocasey
Copy link
Contributor

It appears that this breaks video panning as the video is technically over the canvas. Seems that we also need to set the video elements z-index to something like -1. Seems to work locally with that.

@brandonocasey
Copy link
Contributor

Actually we might even be able and want to use just z-index

@gjanblaszczyk
Copy link
Member Author

Hi @brandonocasey, thanks for the review. Does it look fine now?

Copy link
Contributor

@brandonocasey brandonocasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me 👍

@brandonocasey brandonocasey merged commit 7338726 into videojs:master Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants