Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

custom event for vr initialization #158

Merged
merged 1 commit into from
Aug 13, 2019
Merged

custom event for vr initialization #158

merged 1 commit into from
Aug 13, 2019

Conversation

yichunk
Copy link
Contributor

@yichunk yichunk commented Nov 26, 2018 •
edited
Loading

Description

Trigger an initialization event when the three.js objects are available. It is helpful for someone who wants to add 3D objects in the video.

Specific Changes proposed

add videojs custom event trigger at the end of init() function

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Unit Tests updated or fixed
    • Docs/guides updated
  • Reviewed by Two Core Contributors

@yichunk
Copy link
Contributor Author

yichunk commented Nov 28, 2018 •
edited
Loading

This PR solve my previous issue #157

@brandonocasey brandonocasey merged commit 3c57c23 into videojs:master Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandonocasey brandonocasey brandonocasey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yichunk @brandonocasey