fix: make cardboard button psudeo fullscreen on iOS #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkatsev
reviewed
Aug 8, 2017
src/cardboard-button.js
Outdated
| handleClick() { | ||
| window.dispatchEvent(new window.Event('vrdisplayactivate')); | ||
|
|
||
| handleActivate_() { |
There was a problem hiding this comment.
One thing to look into is whether player.enterFullWindow and player.exitFullWindow work for this usecase.
There was a problem hiding this comment.
does not appear to work
fix: hide cardboard button when fullscreen on Android fix: typo that caused an error in the console
brandonocasey
force-pushed
the
fix/mobile-cardboard
branch
from
27423c0 to
cc42fa0
Compare
misteroneill
requested changes
Aug 8, 2017
src/cardboard-button.js
Outdated
| super(player, options); | ||
|
|
||
| window.addEventListener('vrdisplayactivate', () => this.handleActivate_()); | ||
| window.addEventListener('vrdisplaydeactivate', () => this.handleDeactivate_()); |
There was a problem hiding this comment.
Should probably make sure we clean up after ourselves in a dispose listener.
There was a problem hiding this comment.
good call, going to take some time to do that in player.js too
There was a problem hiding this comment.
scratch that its going to take a revamp of player.js which I would rather do in another PR
mister-ben
pushed a commit
to mister-ben/videojs-vr
that referenced
this pull request
Dec 4, 2023
chore: Swap webvr for webxr polyfill packages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: hide cardboard button when fullscreen on Android
fix: typo that caused an error in the console