Fix/separate big play button #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkatsev
reviewed
Aug 4, 2017
| @@ -351,6 +378,18 @@ const initPlugin = function(player, options) { | |||
| return; | |||
| } | |||
|
|
|||
| player.removeChild('BigPlayButton'); | |||
There was a problem hiding this comment.
we should null (or set to the vr bpb) out player.bigPlayButton as well and restore it on reset
gkatsev
reviewed
Aug 7, 2017
src/plugin.js
Outdated
| const videoEl = player.el().getElementsByTagName('video')[0]; | ||
| const container = player.el(); | ||
| const defaultProjection = settings.projection; | ||
| const oldBigPlayButton = player.BigPlayButton; |
There was a problem hiding this comment.
Also, we probably don't need to store the old one. If it wasn't removed, we can just get the reference via getChild and then set it reset. One less thing to track ourselves here.
There was a problem hiding this comment.
There was a problem hiding this comment.
Bug given that we add a new one in reset, we don't need to store a reference here.
misteroneill
approved these changes
Aug 7, 2017
brandonocasey
force-pushed
the
fix/seperate-big-play-button
branch
from
8b056a3 to
9b58df0
Compare
brandonocasey
force-pushed
the
fix/seperate-big-play-button
branch
from
9b58df0 to
02ecafb
Compare
gkatsev
approved these changes
Aug 7, 2017
mister-ben
pushed a commit
to mister-ben/videojs-vr
that referenced
this pull request
Dec 4, 2023
chore: Swap webvr for webxr polyfill packages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7
Based off of #10