You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks! I submitted a PR which fixes this specific issue, but by the looks of how extensive the changes were between 4.1.0 and 4.1.1, there is potentially more which needs to be addressed.
Description
v4.1.1 is not transpiling es6 syntax correctly. Specifically, arrow functions are not being transpiled. Not an issue in v4.1.0
Steps to reproduce
Explain in detail the exact steps necessary to reproduce the issue.
git clone [email protected]:brightcove/videojs-errors.git
cd videojs-errors
npm i
npm run build
grep "=>" ./dist/videojs-errors.es.js
Observe that there are remaining arrow functions.
git fetch --all --tags --prune
git checkout tags/v4.1.0 -b v410
npm i
npm build
grep "=>" ./dist/videojs-errors.es.js
Observe that there no are remaining arrow functions.
Results
Expected
Expected to see es5 friendly syntax.
Actual
Expected to see es6 syntax, specifically arrow functions.
Error output
If there are any errors at all, please include them here.
Additional Information
Please include any additional information necessary here. Including the following:
versions
videojs
^6.8.0 || ^7.0.0
browsers
what browser are affected?
cli only.
OSes
what platforms (operating systems and devices) are affected?
OSX 10.13.3
plugins
are any videojs plugins being used on the page? If so, please list them below.
No.
The text was updated successfully, but these errors were encountered: