Skip to content
This repository has been archived by the owner on Jan 12, 2019. It is now read-only.

Documentation for event handling outdated? #923

Closed
arendjr opened this issue Nov 24, 2016 · 2 comments
Closed

Documentation for event handling outdated? #923

arendjr opened this issue Nov 24, 2016 · 2 comments

Comments

@arendjr
Copy link

arendjr commented Nov 24, 2016

Description

Regarding events, the documentation says:

Standard HTML video events are handled by video.js automatically and are triggered on the player object. In addition, there are a couple specialized events you can listen to on the HLS object during playback:

It goes on to describe the loadedplaylist event, among others. But if I listen to this event on the HLS object, it seems to never get triggered. Digging into the source it appears I have to listen to the event on the hls.masterPlaylistController_.masterPlaylistLoader_object. However, it feels wrong that I have to listen to this event on a nested object that is considered private.

Am I missing something or is the documentation for this outdated?

Results

Expected

The loadedplaylist event should be triggered on the HLS object. Alternatively, the documentation should describe what is the recommended way of listening to this event.

Additional Information

Please include any additional information necessary here. Including the following:

videojs-contrib-hls version

what version of videojs-contrib-hls does this occur with?
current master branch

videojs version

what version of videojs does this occur with?
current master branch

@imbcmdth
Copy link
Member

imbcmdth commented Feb 3, 2017

We decided to remove the loadedplaylist function since it seems like the function is very much internal to HLS and only bad things can happen if user rely on that function.

The other events are accessible through other means now - mediachange is available via change events on the QualityLevelsList implementation on the player and loadedmetadata is still available on the player.

@imbcmdth imbcmdth closed this as completed Feb 3, 2017
@imbcmdth imbcmdth reopened this Feb 3, 2017
@gesinger
Copy link
Contributor

gesinger commented Feb 6, 2017

Thanks for reporting @arendjr , we have updated the documentation in #992

@gesinger gesinger closed this as completed Feb 6, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants