Skip to content
This repository has been archived by the owner on Jan 12, 2019. It is now read-only.

Abort requests we have no hope of completing in time #1108

Closed
imbcmdth opened this issue May 10, 2017 · 1 comment
Closed

Abort requests we have no hope of completing in time #1108

imbcmdth opened this issue May 10, 2017 · 1 comment
Assignees

Comments

@imbcmdth
Copy link
Member

imbcmdth commented May 10, 2017

We have progress events coming from mediaSegmentRequest that is quite handy. We should leverage that data in that event to decide when to abort a segment request and trigger a rendition switch.

Acceptance Criteria

  • Implement the feature
  • Test it using bandwidth simulator
  • Do a managed release

How

  • Improves ABR -
    • Start up time should improve in low bandwidth scenarios
    • Ability to respond to catastrophic bandwidth drops should improve
      • Should lower rebuffering stats (time and count)
  • Listen for progress events and judge the ability for the player to complete the request in a reasonable time
  • We currently have a hard-timeout. That should be unnecessary in this new world. It might make sense to keep it in the event that progress events are not sent or if they don't contain the kind of data that would allow us to make decisions.
  • We need to update the bandwidth property and trigger the bandwidthchange if we decide to abort because otherwise playlist selection doesn't run

Notes

  • Bandwidth starts off REALLY low on requests
  • The bandwidth simulator DOES simulate progress events (you are welcome)
@mjneil
Copy link
Contributor

mjneil commented Jul 10, 2017

this was added in #1176

@mjneil mjneil closed this as completed Jul 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants