From 582c960bf04eaf61b962937fc6b5e7fae2006f25 Mon Sep 17 00:00:00 2001 From: mister-ben Date: Sat, 25 Mar 2023 07:32:55 +0100 Subject: [PATCH 1/4] Update bug_report.yaml --- .github/ISSUE_TEMPLATE/bug_report.yaml | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.yaml b/.github/ISSUE_TEMPLATE/bug_report.yaml index 17f7010a45..804af2251c 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.yaml +++ b/.github/ISSUE_TEMPLATE/bug_report.yaml @@ -1,6 +1,6 @@ name: General issue description: Report a general issue with Video.js -labels: "needs: triage, bug" +labels: "needs: triage" body: - type: markdown attributes: @@ -10,7 +10,8 @@ body: * Check the [FAQ](https://videojs.com/guides/faqs) and [troubleshooting guides](https://videojs.com/guides/troubleshooting). * If there is an existing open issue for exactly the same problem, comment there instead. * However, be careful not to comment on old, closed issues, the new comment is unlikely to be noticed. - * Take care to make sure it is really the exact same issue. If in doubt, open as a new issue. + * Take care to make sure it is really the exact same issue. Conflating tangentially related issues is counterproductive. If in doubt, open as a new issue. + * Add useful new information, such as a new reproducible case to help define the issue. * If the issue is with a specific plugin, it's often better to open an issue on the plugin repository instead. * Please do take the time to give detailed information, and include a test case. A detailed issue with actionable information will get a better response than a vague anecdote. - type: textarea @@ -26,10 +27,12 @@ body: id: testcase attributes: label: Reduced test case + validations: + required: true description: | Please add a URL to a [reduced test case](https://stackoverflow.com/help/minimal-reproducible-example) where the issue can be observed. We have a [starter template](https://codepen.io/gkatsev/pen/GwZegv?editors=1000#0) on Codepen. - Providing a test case will improve the chances of someone being able to identify the issue quickly. - For a playback problem, including the stream URL is essential. + Without a test case it's unlikely your issue can be actioned. + *For a playback problem, including the stream URL is essential.* placeholder: https:// - type: textarea id: str From b8322836561d48216f01196af020a8cb384d5e9e Mon Sep 17 00:00:00 2001 From: mister-ben Date: Sat, 25 Mar 2023 07:34:32 +0100 Subject: [PATCH 2/4] Update bug_report.yaml --- .github/ISSUE_TEMPLATE/bug_report.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.yaml b/.github/ISSUE_TEMPLATE/bug_report.yaml index 804af2251c..50dab8b157 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.yaml +++ b/.github/ISSUE_TEMPLATE/bug_report.yaml @@ -9,7 +9,7 @@ body: * If you are not reporting a bug, but want to ask a general question, use [discussions](https://github.com/videojs/video.js/discussions) instead. * Check the [FAQ](https://videojs.com/guides/faqs) and [troubleshooting guides](https://videojs.com/guides/troubleshooting). * If there is an existing open issue for exactly the same problem, comment there instead. - * However, be careful not to comment on old, closed issues, the new comment is unlikely to be noticed. + * However, be careful not to comment on old, closed issues. Your new comment is unlikely to be noticed. * Take care to make sure it is really the exact same issue. Conflating tangentially related issues is counterproductive. If in doubt, open as a new issue. * Add useful new information, such as a new reproducible case to help define the issue. * If the issue is with a specific plugin, it's often better to open an issue on the plugin repository instead. From 01ba99d2a00949cd2f6e335a97a0cdd2f2a5461b Mon Sep 17 00:00:00 2001 From: mister-ben Date: Sun, 26 Mar 2023 14:32:40 +0200 Subject: [PATCH 3/4] Update bug_report.yaml --- .github/ISSUE_TEMPLATE/bug_report.yaml | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.yaml b/.github/ISSUE_TEMPLATE/bug_report.yaml index 50dab8b157..73554f5a79 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.yaml +++ b/.github/ISSUE_TEMPLATE/bug_report.yaml @@ -9,10 +9,10 @@ body: * If you are not reporting a bug, but want to ask a general question, use [discussions](https://github.com/videojs/video.js/discussions) instead. * Check the [FAQ](https://videojs.com/guides/faqs) and [troubleshooting guides](https://videojs.com/guides/troubleshooting). * If there is an existing open issue for exactly the same problem, comment there instead. - * However, be careful not to comment on old, closed issues. Your new comment is unlikely to be noticed. + * However, be careful not to comment on old and closed issues. Your new comment is unlikely to be noticed. * Take care to make sure it is really the exact same issue. Conflating tangentially related issues is counterproductive. If in doubt, open as a new issue. - * Add useful new information, such as a new reproducible case to help define the issue. - * If the issue is with a specific plugin, it's often better to open an issue on the plugin repository instead. + * Add useful new information, such as a new reproducible case to help narrow down the issue. + * If the issue is with a specific plugin, it's generally better to open an issue on the plugin repository instead. * Please do take the time to give detailed information, and include a test case. A detailed issue with actionable information will get a better response than a vague anecdote. - type: textarea id: description @@ -25,14 +25,14 @@ body: required: true - type: input id: testcase + validations: + required: true attributes: label: Reduced test case - validations: - required: true description: | Please add a URL to a [reduced test case](https://stackoverflow.com/help/minimal-reproducible-example) where the issue can be observed. We have a [starter template](https://codepen.io/gkatsev/pen/GwZegv?editors=1000#0) on Codepen. - Without a test case it's unlikely your issue can be actioned. - *For a playback problem, including the stream URL is essential.* + *Without a test case* it's unlikely your issue can be actioned. + For a playback problem, including the stream URL is _essential._ placeholder: https:// - type: textarea id: str From 7a12979a7100c7d6522cb7e429c01c9fad985ed9 Mon Sep 17 00:00:00 2001 From: mister-ben Date: Sun, 26 Mar 2023 14:33:29 +0200 Subject: [PATCH 4/4] Update bug_report.yaml --- .github/ISSUE_TEMPLATE/bug_report.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.yaml b/.github/ISSUE_TEMPLATE/bug_report.yaml index 73554f5a79..a89d04c203 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.yaml +++ b/.github/ISSUE_TEMPLATE/bug_report.yaml @@ -31,7 +31,7 @@ body: label: Reduced test case description: | Please add a URL to a [reduced test case](https://stackoverflow.com/help/minimal-reproducible-example) where the issue can be observed. We have a [starter template](https://codepen.io/gkatsev/pen/GwZegv?editors=1000#0) on Codepen. - *Without a test case* it's unlikely your issue can be actioned. + **Without a test case** it's unlikely your issue can be actioned. For a playback problem, including the stream URL is _essential._ placeholder: https:// - type: textarea