fix: evented should cleanup dom data #7350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #7350 +/- ##
==========================================
+ Coverage 79.59% 79.62% +0.03%
==========================================
Files 115 115
Lines 7262 7263 +1
Branches 1745 1745
==========================================
+ Hits 5780 5783 +3
+ Misses 1482 1480 -2
Continue to review full report at Codecov.
|
brandonocasey
commented
Jul 28, 2021
| @@ -499,6 +500,11 @@ function evented(target, options = {}) { | |||
| // When any evented object is disposed, it removes all its listeners. | |||
| target.on('dispose', () => { | |||
| target.off(); | |||
| [target, target.el_, target.eventBusEl_].forEach(function(val) { | |||
There was a problem hiding this comment.
handle disposal of any DomData for the evented object.
gkatsev
approved these changes
Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since
eventedis a mixin, it should cleanup after itself. I migrated the DomData cleanup from Component to the mixin dispose event listener.