fix: don't reset background styles of selected MenuItem when focused #7202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a :not() pseudo class to ensure that the MenuItem background color doesn't get incorrectly reset on mouse focus. Fixes videojs#7200
gkatsev
approved these changes
May 10, 2021
There was a problem hiding this comment.
The easiest way I've found to verify this is to add vjs-hover class to a menu button (like subs caps button or the playback rate button), then, find the selected item under the <vjs-menu> element, and force the :focus state on it. Without this change, you end up no longer being able to read it the text. With this, you can continue seeing the item selected and readable.
Thanks @acmertz!
brandonocasey
approved these changes
May 11, 2021
edirub
pushed a commit
to edirub/video.js
that referenced
this pull request
Jun 8, 2023
Adds a :not() pseudo class to ensure that the MenuItem background color doesn't get incorrectly reset on mouse focus. Fixes videojs#7200
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7200
Description
Fixes a styling issue with the MenuItem component that caused it to display dark text over a dark background when focused, if it was the currently selected MenuItem (
.vjs-selected).Specific Changes proposed
Use
:not(.vjs-selected)to prevent the menu styles from resetting the background of a selected MenuItem on focus.Requirements Checklist