Fix/live tracker ie slowdown #5896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonocasey
commented
Mar 26, 2019
brandonocasey
commented
Mar 26, 2019
brandonocasey
force-pushed
the
fix/live-tracker-ie-slowdown
branch
5 times, most recently
from
fec8ab8 to
156e60e
Compare
brandonocasey
force-pushed
the
fix/live-tracker-ie-slowdown
branch
from
156e60e to
f3af9bd
Compare
gkatsev
reviewed
Mar 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We recently had a fix forOriginally it seemed likesetIntervalperformance in IE 11 but did not realize thatLiveTrackerhas a similarsetInterval. I added a helper to component that should be used for intervals like this in the future.setIntervalalone was the culprit, but after testing it seems that things instartTrackingcan cause the crash so we have to start and stop when the documents visibility changes.