From 475eb38d618755e338c106d7c4b74bf4d83f5e13 Mon Sep 17 00:00:00 2001 From: syranez Date: Thu, 18 Oct 2018 21:53:45 +0200 Subject: [PATCH] Fix: Do not use default button type. The default button type is "submit" which triggers a form submit. Thus if videojs is embedded in a form element the button triggers a form submit. This is the same problem with same solution as discussed in https://github.com/videojs/video.js/issues/2470 --- src/js/tracks/text-track-settings.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/js/tracks/text-track-settings.js b/src/js/tracks/text-track-settings.js index 7530883fb4..9f67954845 100644 --- a/src/js/tracks/text-track-settings.js +++ b/src/js/tracks/text-track-settings.js @@ -464,11 +464,11 @@ class TextTrackSettings extends ModalDialog { return createEl('div', { className: 'vjs-track-settings-controls', innerHTML: [ - `', - `` + `` ].join('') }); }