From 7ebb0ed0b688b500d393a25545b7d01b1373dfba Mon Sep 17 00:00:00 2001 From: Matthew McClure Date: Thu, 30 Oct 2014 13:56:05 -0700 Subject: [PATCH 1/3] localize track off text --- src/js/tracks.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/js/tracks.js b/src/js/tracks.js index fe3f49d5c8..a49ad32b2b 100644 --- a/src/js/tracks.js +++ b/src/js/tracks.js @@ -759,7 +759,7 @@ vjs.OffTextTrackMenuItem = vjs.TextTrackMenuItem.extend({ options['track'] = { kind: function() { return options['kind']; }, player: player, - label: function(){ return options['kind'] + ' off'; }, + label: function(){ return this.localize(options['kind'] + ' off'); }, dflt: function(){ return false; }, mode: function(){ return false; } }; From aba58ec4b98d4f6783ae00f683967d214f152c0c Mon Sep 17 00:00:00 2001 From: Matthew McClure Date: Thu, 30 Oct 2014 14:35:29 -0700 Subject: [PATCH 2/3] can't use this yet here --- src/js/tracks.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/js/tracks.js b/src/js/tracks.js index a49ad32b2b..a8c0c67d68 100644 --- a/src/js/tracks.js +++ b/src/js/tracks.js @@ -759,7 +759,7 @@ vjs.OffTextTrackMenuItem = vjs.TextTrackMenuItem.extend({ options['track'] = { kind: function() { return options['kind']; }, player: player, - label: function(){ return this.localize(options['kind'] + ' off'); }, + label: function(){ return player.localize(options['kind'] + ' off'); }, dflt: function(){ return false; }, mode: function(){ return false; } }; From a2ee66c70034f3ee13f325611f02e51e421848c3 Mon Sep 17 00:00:00 2001 From: Matthew McClure Date: Thu, 30 Oct 2014 16:21:02 -0700 Subject: [PATCH 3/3] move the localization from tracks to menu --- src/js/menu.js | 2 +- src/js/tracks.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/js/menu.js b/src/js/menu.js index 4745debe4e..ac5c3691ef 100644 --- a/src/js/menu.js +++ b/src/js/menu.js @@ -64,7 +64,7 @@ vjs.MenuItem = vjs.Button.extend({ vjs.MenuItem.prototype.createEl = function(type, props){ return vjs.Button.prototype.createEl.call(this, 'li', vjs.obj.merge({ className: 'vjs-menu-item', - innerHTML: this.options_['label'] + innerHTML: this.localize(this.options_['label']) }, props)); }; diff --git a/src/js/tracks.js b/src/js/tracks.js index a8c0c67d68..fe3f49d5c8 100644 --- a/src/js/tracks.js +++ b/src/js/tracks.js @@ -759,7 +759,7 @@ vjs.OffTextTrackMenuItem = vjs.TextTrackMenuItem.extend({ options['track'] = { kind: function() { return options['kind']; }, player: player, - label: function(){ return player.localize(options['kind'] + ' off'); }, + label: function(){ return options['kind'] + ' off'; }, dflt: function(){ return false; }, mode: function(){ return false; } };