Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update mpd-parser to v1.3.1 #8888

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Conversation

wseymour15
Copy link
Contributor

Description

Update MPD parser to v1.3.1

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
    • Has no DOM changes which impact accessiblilty or trigger warnings (e.g. Chrome issues tab)
    • Has no changes to JSDoc which cause npm run docs:api to error
  • Reviewed by Two Core Contributors

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.25%. Comparing base (ffd70b1) to head (59eed52).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8888   +/-   ##
=======================================
  Coverage   83.25%   83.25%           
=======================================
  Files         120      120           
  Lines        8097     8097           
  Branches     1944     1944           
=======================================
  Hits         6741     6741           
  Misses       1356     1356           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gkatsev
Copy link
Member

gkatsev commented Oct 9, 2024

No harm in doing it separately, assuming that VHS is updated before Video.js is released. We've previously waited to bump these to match whatever version VHS includes in its version bump.

@wseymour15
Copy link
Contributor Author

No harm in doing it separately, assuming that VHS is updated before Video.js is released. We've previously waited to bump these to match whatever version VHS includes in its version bump.

Thanks for calling this out. I already bumped the mpd-parser version in VHS, and I am planning to bump the VHS version in video.js tomorrow, before a release 👍

@wseymour15 wseymour15 merged commit 7c17d75 into main Oct 9, 2024
14 checks passed
@wseymour15 wseymour15 deleted the chore/upgrade-mpd-parser-v1-3-1 branch October 9, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants