-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Refresh README.md and point other docs to admin repo #8837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8837 +/- ##
=======================================
Coverage 83.18% 83.18%
=======================================
Files 120 120
Lines 8047 8047
Branches 1931 1931
=======================================
Hits 6694 6694
Misses 1353 1353 ☔ View full report in Codecov by Sentry. |
mister-ben
reviewed
Aug 23, 2024
amtins
reviewed
Aug 23, 2024
Co-authored-by: mister-ben <[email protected]>
amtins
approved these changes
Aug 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏽
mister-ben
approved these changes
Aug 23, 2024
dzianis-dashkevich
approved these changes
Aug 23, 2024
This was referenced Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a long-needed update to the Video.js README. Also, other docs are now pointing to files in the videojs/admin repo.
Specific Changes proposed
vjs.zencdn.net
-hosted versions prior to 7.0.0. The last version that included this was 6.13.0, which was 6 years ago. That seems like enough time to consider the issue dead. Also, Google Analytics likely no longer collects that data as it has moved on from the Universal Analytics API.Requirements Checklist