Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spatial-navigation): refocus available also to the close button of the error modal #8819

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

CarlosVillasenor
Copy link
Contributor

Description

This PR will make the refocus available not only to the buttons of the error modal but also to the close button of the error modal on the event of 'aftermodalfill'.

Specific Changes proposed

Allow the spatial-navigation to refocus the error modal when error modal appears.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
    • Has no DOM changes which impact accessiblilty or trigger warnings (e.g. Chrome issues tab)
    • Has no changes to JSDoc which cause npm run docs:api to error
  • Reviewed by Two Core Contributors

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.73%. Comparing base (daf40bd) to head (9b3ba9b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8819      +/-   ##
==========================================
+ Coverage   83.11%   83.73%   +0.61%     
==========================================
  Files         120      120              
  Lines        8050     8052       +2     
  Branches     1930     1931       +1     
==========================================
+ Hits         6691     6742      +51     
+ Misses       1359     1310      -49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CarlosVillasenor CarlosVillasenor marked this pull request as ready for review July 29, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants