fix: prevent error for root shadow elements when restorEl is enabled #8679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses an issue where activating the `restoreEl` option for an element at the root of a shadow DOM threw a "TypeError: el.parentNode.hasAttribute is not a function". The bug was due to the `parentNode` being a shadow root, which does not have the `hasAttribute` method. The fix implemented checks for the existence of the `hasAttribute` method on `parentNode`.
|
💖 Thanks for opening this pull request! 💖 Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
jboix
added a commit
to SRGSSR/pillarbox-web-theme-editor
that referenced
this pull request
Apr 10, 2024
Added a div container to ensure that the parent of the element passed to video.js is not the shadow root directly. This workaround resolves the issue until a permanent fix is implemented in video-js, see: videojs/video.js#8679
4 tasks
jboix
added a commit
to SRGSSR/pillarbox-web-theme-editor
that referenced
this pull request
Apr 10, 2024
Added a div container to ensure that the parent of the element passed to video.js is not the shadow root directly. This workaround resolves the issue until a permanent fix is implemented in video-js, see: videojs/video.js#8679
github-merge-queue bot
pushed a commit
to SRGSSR/pillarbox-web-theme-editor
that referenced
this pull request
Apr 11, 2024
Added a div container to ensure that the parent of the element passed to video.js is not the shadow root directly. This workaround resolves the issue until a permanent fix is implemented in video-js, see: videojs/video.js#8679
mister-ben
approved these changes
Apr 12, 2024
|
Congrats on merging your first pull request! 🎉🎉🎉 |
This was referenced Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses an issue where activating the
restoreEloption for an element at the root of a shadow DOM threw a "TypeError: el.parentNode.hasAttribute is not a function". The bug was due to theparentNodebeing a shadow root, which does not have thehasAttributemethod.Specific Changes proposed
The fix implemented checks for the existence of the
hasAttributemethod onparentNode.Requirements Checklist