Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced logger #8444

Merged
merged 5 commits into from
Sep 25, 2023
Merged

Enhanced logger #8444

merged 5 commits into from
Sep 25, 2023

Conversation

dzianis-dashkevich
Copy link
Contributor

@dzianis-dashkevich dzianis-dashkevich commented Sep 20, 2023

Description

  • Added the createNewLogger method, to create a logger without a naming chain.
  • Added optional custom delimiter and custom styles.
  • Several improvements in jsDoc for proper types(d.ts) generation.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@videojs videojs deleted a comment from codecov bot Sep 20, 2023
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #8444 (2c535d1) into main (b95cd7a) will increase coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #8444      +/-   ##
==========================================
+ Coverage   82.68%   82.70%   +0.02%     
==========================================
  Files         113      113              
  Lines        7578     7588      +10     
  Branches     1821     1825       +4     
==========================================
+ Hits         6266     6276      +10     
  Misses       1312     1312              
Files Changed Coverage Δ
src/js/utils/create-logger.js 95.00% <100.00%> (+1.00%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@misteroneill misteroneill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dzianis-dashkevich dzianis-dashkevich merged commit cf681e0 into main Sep 25, 2023
11 checks passed
@dzianis-dashkevich dzianis-dashkevich deleted the enhanced-logger branch September 25, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants