Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Resolves captions sizing issue when minified #8442

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

mister-ben
Copy link
Contributor

Description

Fixes issue with sizing captions in #8425.

Specific Changes proposed

Changes test to check for presence of getCueAsHTML instead of the constructor name, as the constructor name is changed when minified.
Open to suggested for a test for this, since the issue only manifested when minified.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
  • Reviewed by Two Core Contributors

@mister-ben mister-ben changed the title Fix captions min fix: Resolves captions sizing issue when minified Sep 19, 2023
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #8442 (6d4e21b) into main (b95cd7a) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #8442   +/-   ##
=======================================
  Coverage   82.68%   82.68%           
=======================================
  Files         113      113           
  Lines        7578     7578           
  Branches     1821     1821           
=======================================
  Hits         6266     6266           
  Misses       1312     1312           
Files Changed Coverage Δ
src/js/tracks/text-track.js 94.23% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@wseymour15 wseymour15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for updating this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants