Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lang): Update fa translation #8288

Merged
merged 1 commit into from
Jun 1, 2023
Merged

fix(lang): Update fa translation #8288

merged 1 commit into from
Jun 1, 2023

Conversation

kerasus
Copy link
Contributor

@kerasus kerasus commented May 22, 2023

Description

update fa translation

  • No content
  • Color
  • Opacity
  • Text Background
  • Caption Area Background
  • Playing in Picture-in-Picture

Specific Changes proposed

fa.json add an option called enableSmoothSeeking

Requirements Checklist

  • [ *] Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@welcome
Copy link

welcome bot commented May 22, 2023

💖 Thanks for opening this pull request! 💖

Things that will help get your PR across the finish line:

  • Run npm run lint -- --errors locally to catch formatting errors earlier.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@mister-ben mister-ben changed the title update fa translation fix(lang): Update fa translation May 23, 2023
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Merging #8288 (e66d160) into main (f1558c6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #8288   +/-   ##
=======================================
  Coverage   82.36%   82.36%           
=======================================
  Files         112      112           
  Lines        7483     7483           
  Branches     1804     1804           
=======================================
  Hits         6163     6163           
  Misses       1320     1320           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@mister-ben mister-ben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mister-ben mister-ben added the needs: LGTM Needs one or more additional approvals label May 23, 2023
Copy link
Member

@misteroneill misteroneill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@misteroneill misteroneill merged commit cb8b329 into videojs:main Jun 1, 2023
@welcome
Copy link

welcome bot commented Jun 1, 2023

Congrats on merging your first pull request! 🎉🎉🎉

edirub pushed a commit to edirub/video.js that referenced this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: LGTM Needs one or more additional approvals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants