-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(shadow-dom): prevent warning 'element supplied is not included' #8192
Conversation
…is not included in the DOM'
…terminal Error message: "zh-Hant)*.json'" is not recognized as an internal or external command operable program or batch file
💖 Thanks for opening this pull request! 💖 Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
Codecov Report
@@ Coverage Diff @@
## main #8192 +/- ##
=======================================
Coverage 82.23% 82.23%
=======================================
Files 112 112
Lines 7430 7432 +2
Branches 1791 1792 +1
=======================================
+ Hits 6110 6112 +2
Misses 1320 1320
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, code changes look good to me and huge thank you for providing an example in addition to a test! 💯
One minor nitpick, but otherwise this looks good to me.
It would be nice if the sample showed a playing video, but ultimately the change does seem to work. That error is not reported. |
@misteroneill yes, being lazy we set autoplay but that's not having effect. We're just now adding a click listener to play/pause. |
@misteroneill just to mention that we've made it so that sandbox example can actually play |
Hi all. Just wondering if there is any update on this, or something more is needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, sorry for the delay on this. I think it's ready to merge.
Congrats on merging your first pull request! 🎉🎉🎉 |
Good news! Bye |
Description
Addresses #8136 . It prevents a misleading warning when video element is created within a custom element.
Specific Changes proposed
Please list the specific changes involved in this pull request.
Requirements Checklist
No codepen example created. Instead there's a dedicated sandbox example.