Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lang): update Japanese translations #8190

Merged
merged 2 commits into from
Mar 15, 2023

Conversation

wseymour15
Copy link
Contributor

Description

Updating a few Japanese translations based on Brightcove's Japanese support team's suggestions.

Specific Changes proposed

  • A few updated translations
  • Update translations needed file

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Merging #8190 (83e247b) into main (35c539d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #8190   +/-   ##
=======================================
  Coverage   82.11%   82.11%           
=======================================
  Files         112      112           
  Lines        7402     7402           
  Branches     1785     1785           
=======================================
  Hits         6078     6078           
  Misses       1324     1324           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be merged as fix, not a chore

@wseymour15 wseymour15 changed the title chore(lang): update Japanese translations fix(lang): update Japanese translations Mar 14, 2023
@wseymour15 wseymour15 merged commit 7e8bd5c into main Mar 15, 2023
@wseymour15 wseymour15 deleted the chore/update-japanese-translations branch March 15, 2023 15:03
edirub pushed a commit to edirub/video.js that referenced this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants