Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

about volume location not at centre at controlBar: {volumePanel: {inline: false}}, at 8.0.3 in chinese #8092

Open
R8KwEwN2hvrhY opened this issue Jan 24, 2023 · 7 comments
Labels
bug needs: triage This issue needs to be reviewed

Comments

@R8KwEwN2hvrhY
Copy link

Description

volume location not at centre at controlBar: {volumePanel: {inline: false}}, at 8.0.3 in chinese
屏幕截图 2023-01-24 152316
Uploading test.txt…

Reduced test case

No response

Steps to reproduce

1.play video in chinese system and explorer
2.
3.

Errors

No response

What version of Video.js are you using?

8.0.3

Video.js plugins used.

No response

What browser(s) including version(s) does this occur with?

chrome 109 zh-cn

What OS(es) and version(s) does this occur with?

windows11

@R8KwEwN2hvrhY R8KwEwN2hvrhY added bug needs: triage This issue needs to be reviewed labels Jan 24, 2023
@mister-ben
Copy link
Contributor

It probably needs this to be changed to line height as was done for the horizontal bar in #7990

Would you be able to test that?

@R8KwEwN2hvrhY
Copy link
Author

It probably needs this to be changed to line height as was done for the horizontal bar in #7990

Would you be able to test that?

i don't know how to do this way.you can provide js command change that,let me try it...use up test.html file

@mister-ben
Copy link
Contributor

Manually changing styles on the element in developer tools is probably the easiest way to work it out. I had a try with Chrome Canary in Chinese, but I haven’t found a value that works for both Chinese and non-Chinese browsers.

@gkatsev
Copy link
Member

gkatsev commented Jan 26, 2023

Manually changing styles on the element in developer tools is probably the easiest way to work it out. I had a try with Chrome Canary in Chinese, but I haven’t found a value that works for both Chinese and non-Chinese browsers.

@mister-ben what about targeting css based on locale like we do for the subscaps button?

@mister-ben
Copy link
Contributor

mister-ben commented Jan 26, 2023

No, we can't target it with :lang() because it's not the language of the page or part of the DOM, or the user language preferences that matter; it's the language the browser is runnning in. I can replicate only by running Chrome in Chinese. It's weird.

@mister-ben
Copy link
Contributor

I see the reason it's different now. If Chrome is running in Chinese, it sets the minimum font size to 12px, (in preferences > appearance > customise font). In other languages it's unset. Our CSS sets the slider handle to .9em, which we expect to be 9px, but on the Chinese browser it's 12px becuase of that min value.

@R8KwEwN2hvrhY
Copy link
Author

R8KwEwN2hvrhY commented Feb 4, 2023

I see the reason it's different now. If Chrome is running in Chinese, it sets the minimum font size to 12px, (in preferences > appearance > customise font). In other languages it's unset. Our CSS sets the slider handle to .9em, which we expect to be 9px, but on the Chinese browser it's 12px becuase of that min value.

i found that at firefox 109 horizontal button has a litle upward,just like follow image
屏幕截图 2023-02-04 150339

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug needs: triage This issue needs to be reviewed
Projects
None yet
Development

No branches or pull requests

3 participants