Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensures iOS can use native fullscreen #8071

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

mister-ben
Copy link
Contributor

Description

#7979 removed a check for an old OS X version but incorrectly, causing iPhones not to use their native fullscreen.

Specific Changes proposed

Returns trues for any video el with webkitEnterFullScreen()

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

Merging #8071 (fd57e4f) into main (df71bb0) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #8071      +/-   ##
==========================================
+ Coverage   81.91%   81.97%   +0.06%     
==========================================
  Files         110      110              
  Lines        7342     7339       -3     
  Branches     1772     1770       -2     
==========================================
+ Hits         6014     6016       +2     
+ Misses       1328     1323       -5     
Impacted Files Coverage Δ
src/js/tech/html5.js 67.18% <100.00%> (+0.87%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mister-ben mister-ben added the patch This PR can be added to a patch release. label Jan 16, 2023
@mister-ben mister-ben merged commit 509b3d0 into videojs:main Jan 24, 2023
edirub pushed a commit to edirub/video.js that referenced this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch This PR can be added to a patch release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants