fix(lang): Improve Persian translation #7991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor typography related improvements. In Persian compound words are joined with Zero-width non-joiner character (\u200c) and this change uses it wherever needed. Also Persian uses a different comma than the English keyboard one and this uses that instead.
Codecov Report
@@ Coverage Diff @@
## main #7991 +/- ##
=======================================
Coverage 82.11% 82.11%
=======================================
Files 112 112
Lines 7402 7402
Branches 1785 1785
=======================================
Hits 6078 6078
Misses 1324 1324 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mister-ben
approved these changes
Nov 6, 2022
misteroneill
force-pushed
the
main
branch
2 times, most recently
from
c1898b4
to
4f8227d
Compare
gkatsev
approved these changes
Feb 1, 2023
|
Great, thanks 😊 |
edirub
pushed a commit
to edirub/video.js
that referenced
this pull request
Jun 8, 2023
Minor typography related improvements. In Persian compound words are joined with Zero-width non-joiner character (\u200c) and this change uses it wherever needed. Also Persian uses a different comma than the English keyboard one and this uses that instead. Co-authored-by: mister-ben <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Minor typography related improvements.
Specific Changes proposed
In Persian compound words are joined with Zero-width non-joiner character (\u200c) and this change uses it wherever needed. Also Persian uses a different comma than the English keyboard one and this uses that instead.
Also used the missing diacritics according to Persian Academy's orthography guidelines.
Feel free to read more about the added character here, https://en.wikipedia.org/wiki/Zero-width_non-joiner