fix: Generate chapters menu only when needed, and don't create orphaned event listeners #7604
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The chapters button can create its menu multiple times if several tracks of any kind are present, and each menu item adds an event listener on the track which is not removed when it is replaced.
Specific Changes proposed
Reduces the instances the menu will be created.
Switches to a single event listener on the menu button to manage its menu's selected item.
Fixes #7595
Requirements Checklist