Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Latvian (lv) language support #7468

Merged
merged 2 commits into from
Nov 10, 2021
Merged

Added Latvian (lv) language support #7468

merged 2 commits into from
Nov 10, 2021

Conversation

edgarsn
Copy link
Contributor

@edgarsn edgarsn commented Oct 5, 2021

Description

Translation file for Latvian language.

Specific Changes proposed

  • lang/lv.json file added

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@welcome
Copy link

welcome bot commented Oct 5, 2021

💖 Thanks for opening this pull request! 💖

Things that will help get your PR across the finish line:

  • Run npm run lint -- --errors locally to catch formatting errors earlier.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

lang/lv.json Outdated
"Done": "Gatavs",
"Caption Settings Dialog": "Parakstu iestatījumi",
"Beginning of dialog window. Escape will cancel and close the window.": "Lai aizvērtu, spiediet ESC taustiņu.",
"End of dialog window.": " ",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is read out screenreaders when they get to the end of a dialogue box, e.g. the captions settings.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it!

@edgarsn
Copy link
Contributor Author

edgarsn commented Oct 27, 2021

Any chance this could get merged?

@gkatsev gkatsev merged commit b97be4d into videojs:main Nov 10, 2021
@welcome
Copy link

welcome bot commented Nov 10, 2021

Congrats on merging your first pull request! 🎉🎉🎉

@gkatsev
Copy link
Member

gkatsev commented Nov 10, 2021

Thanks for your patience, it's in now and a release will likely go out soon.

@edgarsn edgarsn deleted the lv-language-added branch November 23, 2021 13:57
edirub pushed a commit to edirub/video.js that referenced this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants