Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screenreaders don't read video subtitles automatically #7430

Closed
RastislavKish opened this issue Sep 18, 2021 · 10 comments
Closed

Screenreaders don't read video subtitles automatically #7430

RastislavKish opened this issue Sep 18, 2021 · 10 comments
Labels
enhancement outdated Things closed automatically by stalebot

Comments

@RastislavKish
Copy link

Description

Screenreaders don't read subtitles of videos automatically, since the element holding their text doesn't have aria-live attribute enabled.

Steps to reproduce

  1. Open a video with subtitles.
  2. Launch a full-fledged screenreader, like Orca for Linux, NVDA for Windows or VoiceOver for Mac.
  3. Turn video subtitles on.

Results

Expected

The screenreader automatically reads the subtitles as they're appearing on the screen.

Actual

The screenreader doesn't report anything, the user has to manually check whether new text has been shown.

Additional Information

Part of FreeTube accessibility improvements PR by @jasonhenriquez.

versions

videojs

7.14.3

browsers

Tested under Chromium (Electron), though the problem is not browser-related.

OSes

Tested on Ubuntu mate 20.04 64-bit and Windows 10 21H1 64-bit, though the problem is not platform related.

@welcome
Copy link

welcome bot commented Sep 18, 2021

👋 Thanks for opening your first issue here! 👋

If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.
To help make it easier for us to investigate your issue, please follow the contributing guidelines.

@gkatsev
Copy link
Member

gkatsev commented Sep 21, 2021

This is sort of by design to match how browsers work currently. Native captions aren't accessible by screen readers. When a descriptions track is enabled, on non-safari browsers, we make it available for Screen Readers to read.
There's certainly an argument to be made that captions should be accessible to SRs.
@OwenEdwards do you have any insights here?

@gkatsev
Copy link
Member

gkatsev commented Sep 21, 2021

I guess there's some discussion related to this topic here #3554 previously.

@kommunarr
Copy link

A reasonable compromise between the points mentioned in #3554 and the desired utility sought here would be providing an option to enable this behavior.

@OwenEdwards
Copy link
Member

Why is "The screenreader automatically reads the subtitles as they're appearing on the screen." the expected behavior? There is no standard expected behavior defined for this, and as @gkatsev says, the behavior of Video.js with Captions and Subtitles matches the native behavior of browsers when playing video with Captions and/or Subtitles.

@RastislavKish
Copy link
Author

@gkatsev @OwenEdwards I am a screenreader user myself. The conclusion of #3554 is incomplete, as it doesn't take into account the cases where subtitles are used for translation purposes or annotate a video.
Currently, one needs to actively interact with a site to find out whether new text has appeared, what is inconvenient and distractful.

I have no direct experiences with development using VideoJS, so I'm not sure how exactly are the subtitles handled.
But in general:

  • If subtitles are off by default and a user needs to turn them on manually, aria-live should be the default state.
  • if this is upon programmers to decide, there should be a way for them to specify whether the subtitles should be live or not, as @jasonhenriquez suggests (such option should probably be present anyway).

@OwenEdwards
Copy link
Member

OwenEdwards commented Sep 25, 2021

@RastislavKish again, this is not the "expected" behavior, since it doesn't match how browsers behave when they play HTML video with captions or subtitles. I understand that it's a feature that you would like to see added, but it's not a bug.

The problem with what you're asking for is that other screen reader users may complain if video.js changes its behavior by putting captions in an aria-live region, especially for existing videos where a captions track defaults to enabled.

Even if the choice to have aria-live applied to captions were up to the web page developer, this feature could be misused and cause complaints from other screen reader users (because adding aria-live doesn't impact anyone except screen reader users, so developers can be careless with applying it).

The only implementation that would make sense from a user perspective would be for the user to be able to select whether the captions or subtitles are rendered in an aria-live region or not, in the same way that users can specify their own preferences for color, font, background, etc. of how captions and subtitles are rendered visually. So that would need to be a setting in the textTrackSettings modal dialog.

@RastislavKish
Copy link
Author

@OwenEdwards The setting option sounds great. This way, everyone could select the preferred behavior according to their personal preference and needs.
Would be perhaps good to change this to a feature request, if we could go this way.

@gkatsev
Copy link
Member

gkatsev commented Sep 28, 2021

Yes, we can definitely make this a feature request for making captions screen reader accessible by user-request. Though, it's worth noting it'll only be available when native captions aren't being used (which is non-safari by default).

@stale
Copy link

stale bot commented Jan 8, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the outdated Things closed automatically by stalebot label Jan 8, 2022
@stale stale bot closed this as completed Apr 30, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement outdated Things closed automatically by stalebot
Projects
None yet
Development

No branches or pull requests

4 participants