Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add telugu language translation #7391

Merged
merged 1 commit into from
Oct 1, 2021

Conversation

KVPasupuleti
Copy link
Contributor

@KVPasupuleti KVPasupuleti commented Aug 23, 2021

Description

Created a file lang/te.json

which adds a Telugu language translation to the player. Telugu is an Indian Language in Andhra Pradesh state (The original language of the movie Baahubali)

Requirements Checklist

  • Enhancement made
  • Reviewed by Two Core Contributors

@welcome
Copy link

welcome bot commented Aug 23, 2021

💖 Thanks for opening this pull request! 💖

Things that will help get your PR across the finish line:

  • Run npm run lint -- --errors locally to catch formatting errors earlier.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

Copy link
Member

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, I can only verify via Google Translate, but seems good there.

@codecov
Copy link

codecov bot commented Aug 23, 2021

Codecov Report

Merging #7391 (1906d38) into main (2360236) will increase coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7391      +/-   ##
==========================================
+ Coverage   79.55%   79.72%   +0.17%     
==========================================
  Files         115      116       +1     
  Lines        7267     7296      +29     
  Branches     1746     1754       +8     
==========================================
+ Hits         5781     5817      +36     
+ Misses       1486     1479       -7     
Impacted Files Coverage Δ
src/js/control-bar/spacer-controls/spacer.js 85.71% <0.00%> (-14.29%) ⬇️
src/js/video.js 93.75% <0.00%> (-0.79%) ⬇️
src/js/utils/dom.js 63.17% <0.00%> (-0.36%) ⬇️
src/js/control-bar/live-display.js 100.00% <0.00%> (ø)
src/js/control-bar/time-controls/time-divider.js 100.00% <0.00%> (ø)
src/js/control-bar/volume-control/volume-level.js 100.00% <0.00%> (ø)
...ntrol-bar/spacer-controls/custom-control-spacer.js 100.00% <0.00%> (ø)
...rol-bar/text-track-controls/subs-caps-menu-item.js 100.00% <0.00%> (ø)
...-bar/audio-track-controls/audio-track-menu-item.js 3.84% <0.00%> (ø)
src/js/utils/hooks.js 100.00% <0.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2360236...1906d38. Read the comment docs.

@gkatsev gkatsev added the needs: LGTM Needs one or more additional approvals label Aug 23, 2021
@gkatsev gkatsev merged commit 0558096 into videojs:main Oct 1, 2021
@welcome
Copy link

welcome bot commented Oct 1, 2021

Congrats on merging your first pull request! 🎉🎉🎉

@misteroneill misteroneill removed the needs: LGTM Needs one or more additional approvals label May 23, 2023
edirub pushed a commit to edirub/video.js that referenced this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants