-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove IE8 url parsing workaround #7334
Conversation
Codecov Report
@@ Coverage Diff @@
## main #7334 +/- ##
==========================================
+ Coverage 79.53% 79.57% +0.04%
==========================================
Files 115 115
Lines 7270 7262 -8
Branches 1747 1745 -2
==========================================
- Hits 5782 5779 -3
+ Misses 1488 1483 -5
Continue to review full report at Codecov.
|
This reverts commit 3d037c2.
Fun, IE11 fails without this in some cases. Making changing how the removed code works causes it to fail to work as well. So, needs more thought here. |
if (addToBody) { | ||
document.body.removeChild(div); | ||
if (!details.host) { | ||
details.host = window.location.host; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
codecov thinks this isn't covered, but it gets covered in IE11. We just only run coverage in chrome.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is a special comment you can use to skip this if statement.
I think it's /* istanbul ignore if */
from https://github.com/gotwarlost/istanbul/blob/master/ignoring-code-for-coverage.md
No description provided.