Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add try and catch for computedStyle #7214

Merged
merged 2 commits into from
May 11, 2021

Conversation

weiz18
Copy link
Contributor

@weiz18 weiz18 commented Apr 29, 2021

Description

With shadow root enable component, computedStyle gets called on dragging the progress bar. and since we are traversing the path back to the top, if you have a shadow root component in the path, it will try to call computeStyle for shadow root (document fragment) which will then cause the following error
Uncaught TypeError: Failed to execute 'getComputedStyle' on 'Window': parameter 1 is not of type 'Element'.

while (item && item.nodeName.toLowerCase() !== 'html') {

Specific Changes proposed

Adding try and catch so the code can continue to run despite the error

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@welcome
Copy link

welcome bot commented Apr 29, 2021

💖 Thanks for opening this pull request! 💖

Things that will help get your PR across the finish line:

  • Run npm run lint -- --errors locally to catch formatting errors earlier.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

Copy link
Member

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM, just one stylistic nit.

src/js/utils/computed-style.js Outdated Show resolved Hide resolved
@gkatsev gkatsev added the needs: LGTM Needs one or more additional approvals label May 10, 2021
@gkatsev gkatsev merged commit 90ce2d7 into videojs:main May 11, 2021
@welcome
Copy link

welcome bot commented May 11, 2021

Congrats on merging your first pull request! 🎉🎉🎉

@misteroneill misteroneill removed the needs: LGTM Needs one or more additional approvals label May 23, 2023
edirub pushed a commit to edirub/video.js that referenced this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants