fix: add try and catch for computedStyle #7214
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With shadow root enable component, computedStyle gets called on dragging the progress bar. and since we are traversing the path back to the top, if you have a shadow root component in the path, it will try to call computeStyle for shadow root (document fragment) which will then cause the following error
Uncaught TypeError: Failed to execute 'getComputedStyle' on 'Window': parameter 1 is not of type 'Element'.
video.js/src/js/utils/dom.js
Line 620 in 4238f5c
Specific Changes proposed
Adding try and catch so the code can continue to run despite the error
Requirements Checklist