fix: Better text for exit fullscreen #7183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkatsev
approved these changes
Apr 16, 2021
24 tasks
gkatsev
reviewed
Apr 16, 2021
Comment on lines
+572
to
+573
| // Adding less ambiguous text for fullscreen button. | ||
| // In a major update this could become the default text and key. |
There was a problem hiding this comment.
added to our major version tracking list #7068
brandonocasey
approved these changes
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the tooltip/accessibility text for the fullscreen button so it's clearer the action is to leave fullscreen mode.
Adds an English translation within src/video.js rather than make it the default text which would change the translation key.
Updates English and German translations, some existing translations already translate it more like "exit fullscreen".