fix(fs): make sure handlers are unique per player #7035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using Video.js's .bind still makes us attach prototype methods as handlers. Then when one is removed, all handlers are removed. Instead, use arrow methods to make these methods unique. Fixes #7013.
|
Code looks good we probably want to do this for visiblity change handles that we have: video.js/src/js/live-tracker.js Line 55 in 330c82c |
|
That makes sense, I'll make a separate PR for that. |
brandonocasey
approved these changes
Jan 22, 2021
edirub
pushed a commit
to edirub/video.js
that referenced
this pull request
Jun 8, 2023
Using Video.js's .bind still makes us attach prototype methods as handlers. Then when one is removed, all handlers are removed. Instead, use arrow methods to make these methods unique. Fixes videojs#7013.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Video.js's .bind still makes us attach prototype methods as
handlers. Then when one is removed, all handlers are removed.
Instead, use arrow methods to make these methods unique.
Fixes #7013.