-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
memleak on live m3u8 when not start playing #5973
Comments
if put video on pause - the same story. memory not released upon m3u8 update |
Hey, can you show us where in the heap snapshot you were finding the m3u8s? Would make it easier for us to track it down and make sure we're on the same page. |
I looked at it a bit yesterday and I have one simple fix (videojs/http-streaming#487), there's definitely a lot more we need to do. |
Thanks! We're definitely going to schedule time to investigate the memory leaks. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
The source of this leak is in the m3u8 parser: videojs/m3u8-parser#164 |
Description
If open player with live m3u8, but not press start/play, memory will leak not releasing constantly refreshing m3u8.
Steps to reproduce
Explain in detail the exact steps necessary to reproduce the issue.
Results
Expected
Constant memory usage
Actual
Memory usage increase
in 'heap snapshot' (chrome) i see strings objects with m3u8 content.
but outdated content not released, thus adding new string with refreshed m3u8 content every 'target duration' seconds.
as soon as you press 'play', no more string will be leaking. an outdated objects will be released on each m3u8 update.
Error output
no errors
Additional Information
Please include any additional information necessary here. Including the following:
versions
videojs
7.5.4
browsers
Crome.
may be others too.
OSes
MacOS Mojave in my case
plugins
no plugins
The text was updated successfully, but these errors were encountered: