fix: Do not use default button type.

[syranez]

The default button type is "submit" which triggers a form submit. Thus
if videojs is embedded in a form element the button triggers a form
submit.

This is the same problem with same solution as discussed in #2470

[welcome]

💖 Thanks for opening this pull request! 💖

Things that will help get your PR across the finish line:

• Run npm run lint -- --errors locally to catch formatting errors earlier.
• Include tests when adding/changing behavior.
• Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

[misteroneill]

Great catch, thank you!

I searched the source and didn't find any other cases where we'd create a button element that did not have this attribute.

[gkatsev]

Oops. Thanks!

[gkatsev]

Yeah, our Button component has that by default which is nice

video.js/src/js/button.js

Lines 43 to 44 in 313036e

	// Necessary since the default button type is "submit"
	type: 'button'

[welcome]

Congrats on merging your first pull request! 🎉🎉🎉