test: update tests to use qunit 2 assert format #4753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonocasey
force-pushed
the
test/update-qunit
branch
from
6a43ed7 to
9825b0d
Compare
|
Yup, still broken. Not sure why one of the travises passed. |
gkatsev
reviewed
Nov 16, 2017
gkatsev
reviewed
Nov 16, 2017
test/index.html
Outdated
| <link rel="stylesheet" href="../build/temp/video-js.min.css"> | ||
| </head> | ||
| <body> | ||
| <div id="qunit"></div> | ||
| <script src="../node_modules/qunitjs/qunit/qunit.js"></script> | ||
| <script src="../node_modules/qunit/qunit/qunit.js"></script> |
There was a problem hiding this comment.
should these urls be reverted as well?
|
ok everything regarding the version update/name change should be reverted now. |
gkatsev
approved these changes
Nov 16, 2017
gkatsev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We cannot change the package name from
qunitjstoqunitat this time askarma-qunitdoes not supportqunitonly thequnitjspackage name.See: karma-runner/karma-qunit#98
Previously we stopped using an updated qunit as it did not support ie8. This may still be the case and we may not want to update qunit here at all.
This only came up because I wanted to use
Qunit.timeoutin somesourcesettests, but it isn't supported pre v2.