Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: warning, if the element is not in the DOM #4723

Merged
merged 2 commits into from
Nov 7, 2017
Merged

test: warning, if the element is not in the DOM #4723

merged 2 commits into from
Nov 7, 2017

Conversation

odisei369
Copy link
Contributor

Description

Add test to #4698

Specific Changes proposed

Test to make sure that warning is printed, when element given to Video.js is not in the DOM

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

gkatsev
gkatsev approved these changes Nov 7, 2017
View reviewed changes
Copy link
Member

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @odisei369

@gkatsev gkatsev added needs: LGTM Needs one or more additional approvals patch This PR can be added to a patch release. labels Nov 7, 2017
@gkatsev gkatsev added confirmed and removed needs: LGTM Needs one or more additional approvals labels Nov 7, 2017
@gkatsev gkatsev merged commit c213737 into videojs:master Nov 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandonocasey brandonocasey brandonocasey approved these changes

@gkatsev gkatsev gkatsev approved these changes

Assignees
No one assigned
Labels
confirmed patch This PR can be added to a patch release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@odisei369 @gkatsev @brandonocasey