refactor: player.listenForUserActivity_() #4719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkatsev
requested changes
Nov 7, 2017
src/js/player.js
Outdated
|
|
||
| // Min time for setTimeout is 4ms regardless any less number | ||
| // https://www.w3.org/TR/2011/WD-html5-20110525/timers.html#timers | ||
| if (timeout <= 4) { |
There was a problem hiding this comment.
I think we want to keep the 0 check here because while the timer does resolve to 4ms, the value 0 has the special meaning of stopping the inactivityTimeout. A number that isn't zero means that you want a timeout. I think it would be confusing if you set the inactivityTimeout to 2 and then have it not function.
There was a problem hiding this comment.
Hi, does that mean timeout === 0 good enough or it should be at normal timeout < 0, I'm in flavor the first if just 0 if treat it as special
There was a problem hiding this comment.
unfortunately, we should keep the same check because it could break people. We can correct this in a major update.
misteroneill
approved these changes
Nov 13, 2017
misteroneill
added
confirmed
and removed
needs: LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change setTimeout min to 4 as https://www.w3.org/TR/2011/WD-html5-20110525/timers.html#timers
Requirements Checklist