Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor component.ready() #4693

Merged
merged 1 commit into from
Oct 31, 2017
Merged

refactor component.ready() #4693

merged 1 commit into from
Oct 31, 2017

Conversation

kocoten1992
Copy link
Contributor

@kocoten1992 kocoten1992 commented Oct 26, 2017 •
edited
Loading

Requirements Checklist

  • refactor component.ready()

brandonocasey
brandonocasey reviewed Oct 26, 2017
View reviewed changes
src/js/component.js
}

if (sync) {
fn.call(this);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could return after this and get rid of the else here, I think that it would fit better with the new flow of this function.

Copy link
Contributor Author

@kocoten1992 kocoten1992 Oct 26, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uhm no, the point was to easy read/debug, abusing that in only 4 line of code would make thing harder

But feel free to edit anyway

gkatsev
gkatsev approved these changes Oct 27, 2017
View reviewed changes
Copy link
Member

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I could go either way wrt that particular if statement.

@gkatsev gkatsev merged commit b40858b into videojs:master Oct 31, 2017
@Centaurioun Centaurioun mentioned this pull request Dec 14, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandonocasey brandonocasey brandonocasey approved these changes

@gkatsev gkatsev gkatsev approved these changes

Assignees
No one assigned
Labels
confirmed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kocoten1992 @gkatsev @brandonocasey