Bugfix for issue #3100

[mmodrow]

Description

url.js parseUrl drops the protocol from the return object on IE if the url starts with "//:". Chrome returns the current window.location.protocol value in that case. This causes the test mentioned in #3100 to fail on IE, but not on Chrome or FF.

Specific Changes proposed

I added an if-clause to url.js‘s parseUrl to add the current window.location.protocol if the protocol of the given url is empty (or //).

Requirements Checklist

• Feature implemented / Bug fixed
• If necessary, more likely in a feature request than a bug fix
  • Change has been verified in an actual browser (Chome, Firefox, IE)
  • Unit Tests updated or fixed
  • Docs/guides updated
  • Example created (starter template on JSBin)
• Reviewed by Two Core Contributors

[gkatsev]

This is probably fine. I'll have to take a look and see if there might be any issues with this.

[misteroneill]

Overally, seems like a good change/fix. I wonder if it ought to be simply testing !details.protocol instead?

Also, maybe it should be moved above the if (addToBody) {} block to keep the details.protocol conditions together?

[mmodrow]

There should be no protocol that is as well legal as falsy. So !details.protocol sounds good.

You probably refer to the 2nd if (addToBody) in your second suggestion? That should be fine as well.

That would result in a result like:

  if (details.protocol === 'https:') {
    details.host = details.host.replace(/:443$/, '');
  }

  if (!details.protocol) {
    details.protocol = window.location.protocol;
  }

  if (addToBody) {
    document.body.removeChild(div);
  }

  return details;
};

[misteroneill]

Yep, exactly. That'd be great, thanks!

[mmodrow]

Here you are. Thanks for the constructive feedback!

[gkatsev]

Thanks @marcamo!

[mmodrow]

Did I miss some needed action here? As far as I understood everything is fine. Is "needs:testing" still applicable? At the end of the day this fixed the existing tests' failing. So I don't think that Unit Tests updated or fixed, Docs/guides updated or Example created (starter template on JSBin) is applicable, is it?

Or are we simply waiting for a 2nd core contributor approval?