Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Russian translation #4663

Merged
merged 3 commits into from
Oct 30, 2017
Merged

Update for Russian translation #4663

merged 3 commits into from
Oct 30, 2017

Conversation

estim
Copy link
Contributor

@estim estim commented Oct 14, 2017

Update for Russian translation

estim added 2 commits October 14, 2017 12:06
Russian translation updated
Russian translation updated
Copy link
Member

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a question about Pause. The rest looks good.

lang/ru.json Outdated
"Play": "Воспроизвести",
"Pause": "Приостановить",
"Pause": "Пауза",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't Пауза a noun where-as Приостановить a verb, so, Приостановить would be more appropriate?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think that's a good point to have here a verb instead of a noun.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@estim can you revert this line change then? I can do it otherwise before merging.
Thanks.

@gkatsev gkatsev merged commit 45e21fd into videojs:master Oct 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants