Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Vietnamese #4625

Merged
merged 2 commits into from
Oct 2, 2017
Merged

Update Vietnamese #4625

merged 2 commits into from
Oct 2, 2017

Conversation

ngoisaosang
Copy link
Contributor

@ngoisaosang ngoisaosang commented Sep 20, 2017 •
edited
Loading

Description

Fix and update lang

Specific Changes proposed

Please list the specific changes involved in this pull request.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@ngoisaosang
Update Vietnamese
fd26779 
Fix and update lang
gkatsev
gkatsev reviewed Sep 20, 2017
View reviewed changes
Copy link
Member

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

Can you remove package-lock.json? We're not ready to update to npm5 just yet.

@misteroneill misteroneill merged commit ac58dbf into videojs:master Oct 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkatsev gkatsev gkatsev left review comments

@brandonocasey brandonocasey brandonocasey approved these changes

@misteroneill misteroneill misteroneill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ngoisaosang @misteroneill @gkatsev @brandonocasey