feat: add remainingTimeDisplay method #4620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonocasey
force-pushed
the
feat/better-remaining-time
branch
from
fd889ba to
4e4f779
Compare
|
We'd want to update the remainingTimeDisplay to pass in Math.floor (or something else) as well. |
|
Also, I'm still not sure this is the direction we want as it requires the user to know how format time works to know what to pass in if the user wants to use it for displaying themselves. |
|
After some more exhaustive testing http://jsbin.com/nohawin/1/edit?js,output it seems that floor/floor is the only possible way for this to work. So I think that we shouldn't even provide a custom rounding override option. |
brandonocasey
force-pushed
the
feat/better-remaining-time
branch
from
4e4f779 to
602768d
Compare
gkatsev
changed the title
gkatsev
added
the
minor
misteroneill
approved these changes
Sep 29, 2017
brandonocasey
force-pushed
the
feat/better-remaining-time
branch
2 times, most recently
from
85e0f38 to
d51dfbb
Compare
brandonocasey
force-pushed
the
feat/better-remaining-time
branch
from
d51dfbb to
cc952fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow remainingTime to be given a rounding function during use. Add a function which should be used as the default when displaying remaining time.
Fixes #4608
Requirements Checklist