Use passive event listeners for touchstart/touchmove #4440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/js/utils/events.js
Outdated
| let options = false; | ||
|
|
||
| if (_supportsPassive && | ||
| ['touchstart', 'touchmove'].indexOf(type) > -1) { |
There was a problem hiding this comment.
I wonder if this array ought to be defined once in the parent scope rather than inline. Something like:
const passiveEvents = [
'touchstart',
'touchmove'
];
gkatsev
reviewed
Jun 26, 2017
src/js/utils/events.js
Outdated
| */ | ||
| let _supportsPassive = false; | ||
|
|
||
| try { |
There was a problem hiding this comment.
we should wrap this try/catch in an iife.
|
Looks like this will fix #4432 (we should not that in the merge commit). |
gkatsev
approved these changes
Jun 26, 2017
|
We probably should make this against 5.x as well. |
4 tasks
gkatsev
pushed a commit
that referenced
this pull request
Jul 4, 2017
biggun1860
added a commit
to biggun1860/video.js
that referenced
this pull request
Jul 29, 2017
fix: Use passive event listeners for touchstart/touchmove (videojs#4440)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Not using passive event listeners now causes Chrome to log warnings to the console, and possibly has a performance impact
Fixes #4432
Specific Changes proposed
Where supported, use passive event listeners for
touchmoveandtouchstartRequirements Checklist