Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update a translation key to match correct string #4383

Merged
merged 1 commit into from
Jun 28, 2017

Conversation

mister-ben
Copy link
Contributor

Description

The lang files were translating "all settings to the default values" instead of "restore all settings to the default values".

Specific Changes proposed

  • Updated the key in all lang files already using it
  • Updated the French translation and added some further missing German translations

@h0lysl4y3r the Slovakian translation probably needs an update now.

Requirements Checklist

  • Feature implemented / Bug fixed
  • Change has been verified in an actual browser (Chome, Firefox, IE)
  • Reviewed by Two Core Contributors

@gkatsev
Copy link
Member

gkatsev commented May 30, 2017

I wonder if the string should just be all settings to the default values. I think it was supposed to be so that the screen reader would read: Reset all settings to the default values but if we add restore into the translations, it'll be doubled up and it'll read Reset restore all settings to the default values.

@mister-ben
Copy link
Contributor Author

Ah, but that wouldn't work for some languages because of the word order.

@gkatsev gkatsev merged commit e0824c8 into videojs:master Jun 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants